This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Enable signature verification in background task#10353
Closed
librelois wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
@bkchr I would like to have a first feedback about the design, can you answer the following questions? (or tag someone who could)
|
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
Bot
added
the
A5-stale
Contributor
Author
|
I am still working on this PR, I am waiting for a feedback from @bkchr |
stale
Bot
removed
the
A5-stale
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
Bot
added
the
A5-stale
Contributor
Author
|
I can't reopen this PR, so I created a new one: #10946 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring back signature batch verification but with the new name background verification.
Indeed, batch verification - in the cryptographic sense - is a different feature, and only exists for certain types of signatures.
Batch verification is currently only implemented for signatures of type sr25519. For the other types of signatures (ed25519 and ecdsa), each signature is verified alone but in a background task.
Some questions about the design:
Added an optimization suggested by @crystalin: in case the first extrinsics are particularly long to run, the background tasks that check the signatures will do nothing for a while, which is suboptimal.
It is more optimal to spawn all the signatures to be checked in the background before starting to run the extrinsics.
Closes paritytech/polkadot-sdk#351